🤖 feat: add guard-anchored file_edit_insert tool #579
Conversation
ammar-agent
force-pushed
the
remove-file-edit-insert
branch
from
5f3cdbc to
3791c66
Compare
ammar-agent
changed the title
ammar-agent
force-pushed
the
remove-file-edit-insert
branch
from
565c5eb to
79e3c6b
Compare
The file_edit_insert tool led to more issues than benefits (unreliable line offset calculations and edge cases). Standardize on file_edit_replace_string as the primary file editing tool. Changes: - Remove file_edit_insert tool and all references - Remove from tool definitions and type exports - Update UI components to only support replace_string and replace_lines - Update tests and tool policies - Update integration tests to use file_edit_replace_string All 987 unit tests pass; typecheck is clean.
Generated with `mux`
Generated with
Generated with
Generated with
Generated with
Generated with
ammar-agent
force-pushed
the
remove-file-edit-insert
branch
from
73098b7 to
d9622c3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function insertContent( | ||
| originalContent: string, | ||
| contentToInsert: string, | ||
| options: InsertContentOptions | ||
| ): InsertOperationSuccess | InsertOperationFailure { | ||
| const { before, after } = options; | ||
|
|
||
| if (before !== undefined && after !== undefined) { | ||
| return guardFailure("Provide only one of before or after (not both)."); | ||
| } | ||
|
|
||
| if (before === undefined && after === undefined) { | ||
| return guardFailure("Provide either a before or after guard to anchor the insertion point."); | ||
| } |
There was a problem hiding this comment.
The new insert helper always returns an error when neither before nor after guards are provided, which means there is no way to write into an existing empty file—the file has no substrings to anchor against, and the create flag is ignored once the file already exists. Any invocation against a zero‑byte file will therefore always fail with “Provide either a before or after guard…”, making the tool unusable for initializing empty files (a capability the previous line_offset API supported). Consider falling back to inserting at the top of the file when it is empty or when guards are omitted, so agents can still populate empty files without resorting to other tools.
Useful? React with 👍 / 👎.
2 participants
Summary
Testing
Generated with
mux